bleistift2 @ bleistift2 @sopuli.xyz

Posts

61

Comments

903

Joined

1 yr. ago

porn family plan

not to be confused with the family porn plan.

I was afraid you’d say that. That’s stupid.

Do they give a reason for why that’s ‘necessary’?

(Also it should be const userToName = (user) => user.name;)

Thanks for doing what I was too lazy to do.

I refuse to enter any club that would accept me as a member.

even property/field access is extracted out to a function

Java, the most functional programming language there is.

Same story here. I didn’t pay attention and failed basic math. Suggestion: plumber.

The German agency for civil protection [badly translated] has recommended having a stockpile of supplies that lasts for 3 days, preferrably 7–10 days, for ages. We Germans collectively ignore that.

PDF, German: https://www.bbk.bund.de/SharedDocs/Downloads/DE/Mediathek/Publikationen/Buergerinformationen/Ratgeber/ratgeber-notfallvorsorge.pdf?__blob=publicationFile

Medium brain aneurysm?

Correct answer: Lay off everyone. The new project will be coded solely by AI. 💯 hired.

First.

One guy isn’t living in that moment.

Seems plausible. When you edit the page and render a preview without changing anything, the formulas render correctly.

I guess it’s easier and safer to make a string replace for each function name beforehand than hoping the compression algorithm will figure that out.

Also, as SpaceCowboy points out, comments are completely useless for the final web page. There’s no need to even compress them.

I’ve thought about setting whole ‘images’ inside the canvas at once, but that would probably ruin the pixel-by-pixel style OP was going for. Do you have a suggestion how that could be maintained while not drawing every pixel individually?

With all these comments said, I experience no problems in Firefox on Linux, and I really like the art style. If one browser is troublesome to you, check which function(s) really are the culprit. (This is actually true for any optimization: Only optimize the stuff that’s slow (duh)).

script.js, ll. 57ff.

    
    fillRect() {
        var sideColor = this.on_side_one ? this.c_side_1 : this.c_side_2;
        ctx.fillStyle = sideColor;
        ctx.fillRect(g_pixelOffset + (g_pixelOffset * this.x), g_pixelOffset + (g_pixelOffset * this.y), this.radius, this.radius);
    }

  

All these computations don’t have to be delayed until you’re actually drawing the dot. If you’d compute them when you’re creating the dot, the rendering might become smoother.

You’re mixing spaces and tabs for indentation. This makes it hard to read for anyone whose tab settings aren’t the same as yours.

script.js, ll. 788ff.

    
for (var i = 0; i < elements.length; i++)

  

If you’re not using the index of an iteration, you might as well use the array iterator. This is more of a legibility improvement rather than a performance improvement.

    
for (const element of elements)

  

First: For every performance optimization you do, you must actually measure if it improves things. It could be that you’re doing a perfectly sensible optimization, which turns out to work against the compiler (yes, even JavaScript is compiled) and thus decreases performance.

In script.js, l.149ff:

    
    drawImage(Image, topLeftX, topLeftY) {
        for (let row = 0; row < Image.length; row++) {
            for(let column = 0; column < Image[row].length; column++) {
                this.nextFrame[(topLeftX + column)*this.height + (topLeftY+row)] = Image[row][column];
            }
        }
    }

  

The term topLeftX + column * this.height can be rewritten as topLeftX * this.height + column * this.height. The first term of this is a constant and can be extracted into a variable const verticalOffset = topLeftX * this.height.

Similarly, topLeftY + row doesn’t need to be recomputed in every iteration of the inner for loop. Move it out into the outer for loop.

Also notice that the variable part, column * this.height is all the integer multiples of this.height. Therefore, instead of a multiplication, you can simply add this.height to a running total. Sums should be faster than multiplications.

With these three changes you get [Edit: I think I made mistakes during the replacements.]

    
drawImage(Image, topLeftX, topLeftY) {
    const TODO_NAME_THIS = topLeftX * this.height
    let TODO_NAME_THIS_ALSO = topLeftY
    for (let row = 0; row < Image.length; row++) {
        let TODO_NAME_THIS_TOO = 0
        for(let column = 0; column < Image[row].length; column++) {
            this.nextFrame[TODO_NAME_THIS + TODO_NAME_THIS_TOO + TODO_NAMES_THIS_ALSO] = Image[row][column];
            TODO_NAME_THIS_TOO += this.height
        }
        TODO_NAME_THIS_ALSO += row
    }
}